Repository navigation
refactor(sync): remove Phase 1 source references - #1005
Merged
Merged
Conversation
This was referenced Nov 3, 2026
(cherry picked from commit bfe91d0)
ctawiah
force-pushed
the
ctawiah/sync-phase1-ref-removal-3bbf
branch
from
November 4, 2026 15:29
25198b7 to
140c3bc
Compare
ctawiah
marked this pull request as ready for review
November 4, 2026 15:29
ctawiah
requested review from
nkester-ld and
tiffanylphan
and removed request for
a team
November 4, 2026 15:29
nkester-ld
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Phase 1 linked a prompt to a repository file through a
refentry in the front matter of its managed file, with one plain Markdown adapter. The.ref.yamldescriptors in the next pull requests replace that design.What changes
reffront matter field.sync prompts linkcommand and its planner and executor branches.Design notes
Review focus
Verification
make buildgo test ./...golangci-lint run ./...Related changes
🤖 Generated with Claude Code
Note
Overview
This PR removes the Phase 1 “linked prompt” model so sync no longer supports variation wrappers that point at external repo files via YAML
reffront matter. It is deletion-only groundwork before.ref.yamldescriptors land in follow-up PRs.CLI and actions:
ldcli sync prompts linkis gone, along withLinkAction,linkTarget, and runner wiring that created a linked variation then ran sync.Deleted packages:
internal/sync/link(link workflow),internal/sync/referenceand the plain-markdown adapter, andinternal/sync/local/reference.go(path validation and reading linked files).Local workspace: Variations are inline only—compile no longer merges content from referenced files;
VariationFile/ front matter dropRef;ReplaceVariationsno longer rewrites external prompt files on pull;SourceFilesand watch tests no longer treat repo paths outside.launchdarklyas sync inputs.Planner / executor / lock: Manifest entries no longer store
ref;SetRefs,planRestore, and post-sync ref recording are removed. Pull-to-local no longer passesrestoreRef.Tests: Flag inventories, acceptance scenarios for linked push/pull/detach/restore, and link-specific unit tests are removed or trimmed accordingly.
Note for reviewers: Stale comments in
watch.go/compile.gostill mention linked files; behavior now follows managed files only viaSourceFiles.Reviewed by Cursor Bugbot for commit 140c3bc. Bugbot is set up for automated code reviews on this repo. Configure here.